Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed Limit field no longer appears in the United States and Canada #388

Closed
1ec5 opened this issue Feb 3, 2022 · 2 comments
Closed

Speed Limit field no longer appears in the United States and Canada #388

1ec5 opened this issue Feb 3, 2022 · 2 comments
Labels
bug Something isn't working field priority

Comments

@1ec5
Copy link
Contributor

1ec5 commented Feb 3, 2022

URL

https://ideditor.netlify.app/#background=Bing&disable_features=boundaries&id=w648312143&locale=en&map=19.00/39.44204/-83.82872

How to reproduce the issue?

  1. Select a street.
  2. Observe that the Speed Limit field is no longer present in the inspector, even though Advisory Speed Limit is available as a field that can be added.

Screenshot(s) or anything else?

#217 added a maxspeed field specific to the United States and Canada, but it isn’t showing up for some reason. Meanwhile, the global maxspeed field is being correctly excluded. As a result, iD ends up with no Speed Limit field at all.

Which iD Editor versions do you see the issue on?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.com

Which browsers are you seeing this problem on?

Firefox

@1ec5 1ec5 added bug Something isn't working field labels Feb 3, 2022
@tyrasd tyrasd added the priority label Feb 3, 2022
@tyrasd
Copy link
Member

tyrasd commented Feb 3, 2022

oh that's bad 😢 it was my mistake in 8c59cda, where I forgot to remove the locationSet -> exclude from the maxpeed field.

@tyrasd tyrasd closed this as completed in 4dd3f40 Feb 3, 2022
@tyrasd tyrasd transferred this issue from openstreetmap/iD Feb 3, 2022
@1ec5
Copy link
Contributor Author

1ec5 commented Feb 3, 2022

Ah, thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working field priority
Projects
None yet
Development

No branches or pull requests

2 participants