-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update template bundle #1058
fix: update template bundle #1058
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/engine-cli/template/designer/public/mock/bundle.json (1)
14041-14046
: Consider using fixed versions instead of ranges in CDN URLs.The TinyVue CDN URLs use version ranges (
~3.14
) which could potentially pull in incompatible updates. Consider using exact versions like you did with Element Plus to ensure consistent builds.- "script": "https://unpkg.com/@opentiny/vue@~3.14/runtime/tiny-vue.mjs", - "css": "https://unpkg.com/@opentiny/vue-theme@~3.14/index.css" + "script": "https://unpkg.com/@opentiny/[email protected]/runtime/tiny-vue.mjs", + "css": "https://unpkg.com/@opentiny/[email protected]/index.css"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/engine-cli/template/designer/public/mock/bundle.json
(33 hunks)
🔇 Additional comments (1)
packages/engine-cli/template/designer/public/mock/bundle.json (1)
14040-14054
: Verify package versions and check for security advisories.The package versions should be verified to ensure they exist and are free from known vulnerabilities.
✅ Verification successful
✓ Package versions verified and security check passed
Both packages exist in the npm registry and are using fixed versions:
- @opentiny/[email protected]
- [email protected]
No active security vulnerabilities found in the specified versions.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if package versions exist and scan for security advisories # Check if TinyVue v3.14.0 exists curl -s https://registry.npmjs.org/@opentiny/vue/3.14.0 | jq '.version' # Check if Element Plus v2.4.2 exists curl -s https://registry.npmjs.org/element-plus/2.4.2 | jq '.version' # Check for security advisories gh api graphql -f query=' { securityVulnerabilities(first: 5, ecosystem: NPM, package: "element-plus") { nodes { advisory { summary severity publishedAt } vulnerableVersionRange firstPatchedVersion { identifier } } } }'Length of output: 743
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
What is the current behavior?
Issue Number: N/A
What is the new behavior?
根据物料新协议更新cli模板中的bundle.json
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
TinyVue组件库
version 3.14.0element-plus组件库
version 2.4.2Refactor