Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The tab supports editing the title and name #1157

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

xuanlid
Copy link
Contributor

@xuanlid xuanlid commented Feb 27, 2025

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

Fixes #1106
标签页组件可以配置tab title 和 tab name
tab title —>页签名
tab name —>页签ID
image

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Introduced a conditional header for TinyTabs displaying tab name and ID.
    • Added an input field that lets users update tab names.
    • Updated the add-tab button with an icon for enhanced visual feedback.
  • Style

    • Refined layout and appearance for the new header and button.
    • Added new customizable theme settings for background and border colors.

Copy link
Contributor

coderabbitai bot commented Feb 27, 2025

Walkthrough

This pull request updates the configurator component by introducing new conditional rendering for the TinyTabs component. It adds a header with two div elements displaying "页签标题" and "页签值", a tiny-input for editing data.props.name, and a modified button featuring an SVG icon. Additionally, the setup function now returns a new componentName, and new CSS custom properties have been added to enhance styling for background and border colors.

Changes

File(s) Change Summary
packages/configurator/src/container-configurator/ContainerConfigurator.vue Adds a conditional header for the TinyTabs component with two divs ("页签标题" and "页签值"), a tiny-input field for editing data.props.name, updates the add-tab button with an SVG icon, and returns componentName in the setup.
packages/configurator/src/styles/vars.less Adds two new CSS variables: --te-configurator-container-bg-color (using var(--te-common-bg-container)) and --te-configurator-container-border-color-divider (using var(--te-common-border-bg-divider)) for styling.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant CC as ContainerConfigurator
    participant UI as UI Renderer

    U->>CC: Load component
    CC->>UI: Check if component is TinyTabs
    alt TinyTabs Component Active
        UI->>UI: Render header with "页签标题" and "页签值"
        UI->>UI: Render tiny-input for data.props.name
        UI->>UI: Render button with SVG icon
    end
Loading

Possibly related PRs

Suggested labels

enhancement

Suggested reviewers

  • hexqi
  • lichunn

Poem

I'm a rabbit with a coding flair,
Hopping through changes with style to spare.
New tabs and headers now shine bright,
In CSS and Vue, everything is just right! 🐇🎉
Leaping into code with a joyful light.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f3ca6a and 5fc980a.

📒 Files selected for processing (1)
  • packages/configurator/src/container-configurator/ContainerConfigurator.vue (4 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/configurator/src/container-configurator/ContainerConfigurator.vue
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: push-check

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature]: Tabs选项卡组件是否可以支持绑定变量!!!
1 participant