Remove ngraph::Lambda class, replace TensorIterator body with ngraph::Function #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itikhono
requested review from
ilyachur,
mbencer,
GlebKazantaev,
arogowie-intel and
a team
openvino-pushbot
added
category: inference
ilyachur
reviewed
Aug 18, 2020
GlebKazantaev
approved these changes
Aug 18, 2020
itikhono
requested review from
mikhail-treskin,
ilyachur,
GlebKazantaev and
a team
GlebKazantaev
approved these changes
Aug 18, 2020
ilyachur
approved these changes
Aug 18, 2020
…Graph [ONNX][Loop] Fix passing parameters from parent graph scope to subgraph
mbencer
reviewed
Aug 18, 2020
| @@ -100,6 +100,7 @@ namespace ngraph | |||
| NGRAPH_API | |||
| NodeVector as_node_vector(const OutputVector& values); | |||
| /// Returns a ResultVector referencing values. | |||
| NGRAPH_API | |||
There was a problem hiding this comment.
@ilyachur Is it ok to expose as_result_vector? (it is used in onnx importer)
There was a problem hiding this comment.
I am ok this this change, if it is required for external components.
tomdol
approved these changes
Aug 18, 2020
ilyachur
approved these changes
Aug 19, 2020
mryzhov
pushed a commit
to mryzhov/openvino
that referenced
this pull request
Aug 26, 2020
…:Function (openvinotoolkit#1830) * remove Lambda class, replace TensorIterator body with ngraph::Function * Fix passing parameters from parent graph to subgraph Co-authored-by: mbencer <[email protected]>
RomanZm
pushed a commit
to RomanZm/openvino
that referenced
this pull request
Aug 28, 2020
…:Function (openvinotoolkit#1830) * remove Lambda class, replace TensorIterator body with ngraph::Function * Fix passing parameters from parent graph to subgraph Co-authored-by: mbencer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
ngraph::Lambdaclass.Moved the functionality to
ngraph::FunctionReplaced use of
ngraph::Lambdawithngraph::FunctionAfter removing Lambda it turned out that passing parameters (not initializes) from parent graph to subgraph does not work correctly (as a result a few unit tests fail). Necessary changes were made by @mbencer in this PR itikhono#1