Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Germany, state Baden-Wuerttemberg entries for meetups and mailing lists #356

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

okilimu
Copy link
Contributor

@okilimu okilimu commented Jun 21, 2020

I wasn't able to check completely local with npm run test, sorry

@bhousel
Copy link
Member

bhousel commented Jun 22, 2020

thanks @okilimu , it looks pretty good 👍
I see a few warnings that some of the geojsons cover a very small area - in these situations the geojson is kind of wasteful, so we usually just specify a point.

Points as [longitude, latitude] coordinate pairs. A 25km radius circle will be computed around the point.
Example: [8.67039, 49.41882]

I'll convert them and merge, if that's ok?

@okilimu
Copy link
Contributor Author

okilimu commented Jun 22, 2020

you can use a point instead, thats ok.
Should i define the point and sent a new pull request or do you make the changes for yourself?

@bhousel
Copy link
Member

bhousel commented Jun 22, 2020

Should i define the point and sent a new pull request or do you make the changes for yourself?

I'll just make the change - just wanted to ask first!

@bhousel bhousel merged commit db81510 into osmlab:master Jun 23, 2020
bhousel added a commit that referenced this pull request Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants