Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunk deleting of rows from the activity table #610

Merged
merged 1 commit into from
Mar 13, 2018
Merged

Chunk deleting of rows from the activity table #610

merged 1 commit into from
Mar 13, 2018

Conversation

tomneedham
Copy link
Contributor

Fixes for clustered environments, which have a limit on rows and size of data affected by each transaction due to replication concerns.

@tomneedham tomneedham added this to the development milestone Feb 15, 2018
@tomneedham tomneedham self-assigned this Feb 15, 2018
@tomneedham
Copy link
Contributor Author

Need to test this manually as well - WIP

@tomneedham
Copy link
Contributor Author

tomneedham commented Feb 21, 2018 •
edited
Loading

So it turns out postgres and sqlite all don't like limits in their delete statements.

@codecov-io
Copy link

codecov-io commented Feb 21, 2018 •
edited
Loading

Codecov Report

Merging #610 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #610      +/-   ##
===========================================
+ Coverage     86.54%   86.6%   +0.06%     
- Complexity      491     493       +2     
===========================================
  Files            36      36              
  Lines          1754    1762       +8     
===========================================
+ Hits           1518    1526       +8     
  Misses          236     236
Impacted Files Coverage Δ Complexity Δ
lib/Data.php 92.41% <100%> (+0.29%) 47 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227819f...84e6f26. Read the comment docs.

@tomneedham tomneedham mentioned this pull request Mar 9, 2018
Closed
@GrendelOnCampus
Copy link

Hello Tom.
I really like that. Can I apply this patch to 10.0.4?

PVince81
PVince81 approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks fine

@tomneedham
Copy link
Contributor Author

This will apply on top of v2.3.6 and will appear in the marketplace pending QA

@GrendelOnCampus
Copy link

Ok, hopefully there'll be an update next week of activity app... :-)
Thank you...

@pako81 pako81 merged commit 2c42537 into master Mar 13, 2018
@pako81 pako81 deleted the chunk-celanup branch March 13, 2018 13:20
@PVince81 PVince81 modified the milestones: development, QA Jun 26, 2018
@madsi1m
Copy link

madsi1m commented Aug 23, 2018

Hi can this please be added to stable10?

@DeepDiver1975
Copy link
Member

Grab version 2.3.7 from the marketplace - this holds this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@pako81 pako81 pako81 approved these changes

Assignees

@tomneedham tomneedham

Labels
3 - To review blue-ticket p2-high sev2-high
Projects
None yet
Milestone
2.3.7
Development

Successfully merging this pull request may close these issues.
7 participants
@tomneedham @codecov-io @GrendelOnCampus @madsi1m @DeepDiver1975 @PVince81 @pako81