if object_name empty for file activity, derive file path from filecache info path #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #875 +/- ##
=========================================
Coverage 84.12% 84.12%
Complexity 504 504
=========================================
Files 47 47
Lines 1896 1896
=========================================
Hits 1595 1595
Misses 301 301
Continue to review full report at Codecov.
|
mrow4a
force-pushed
the
bugfix/fix-not-found-preview
branch
from
05a808a to
d0356b9
Compare
mrow4a
force-pushed
the
bugfix/fix-not-found-preview
branch
from
d0356b9 to
ca8da3a
Compare
mrow4a
commented
Jul 21, 2020
mrow4a
force-pushed
the
bugfix/fix-not-found-preview
branch
from
ca8da3a to
611abc4
Compare
|
@DeepDiver1975 could you re-review ? |
karakayasemi
force-pushed
the
bugfix/fix-not-found-preview
branch
from
611abc4 to
fd25909
Compare
|
Rebased to be able to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some activities, no object_name is stored (for rename, tags, comment, tag). Thus path cannot be derived from object_name and preview are wrongly shown:
This PR fixes it