-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User management] Invalid email address keeps in textfield and no alert is shown #13503
Comments
This merge #13519 has worsen this issue, now many invalid email addreses are accepted and stored in database. |
@SergioBertolinSG PR #13519 doesn't changes anything from perspective of this issue. |
@SergioBertolinSG The PR doesn't put invalid emails into the database. It is just wrongly shown. But this is another issue of just a temporary wrong info presented. I will have a look at this once I worked on the more critical stuff that is out there. |
I have to disagree, take a look to the oc_preferences table: |
Okay. I didn't noticed that. I will have a look. |
@DeepDiver1975 I will maybe propose a fix for that and would like it in 8.0 because it seems there is a regression, but I first will test this. |
@MorrisJobke looks like phpmailer always uses 'pcre/pcre8' validation, which not so strict and doesn't requires to have dot in email address. Forcing 'php' validation fixes server-side part: return PHPMailer::ValidateAddress($emailAddress, 'php'); but it doesn't supports international addresses -_- html5 validation regex also consider emails without dot as valid |
These are all valid email addresses https://en.wikipedia.org/wiki/Email_address#Domain_part (see linked RFC there - there are multiple in the text and also valid email addresses listed) |
Steps to reproduce
Using an administrator account:
Expected behaviour
An alert is shown warning that email address isn't valid and textfield is deleted.
Actual behaviour
Wrong email address keeps in the textfield, it isn't erased and alert is not shown.
Server configuration
Operating system:
Ubuntu 14.04 LTS
Web server:
Apache
Database:
MySQL
PHP version:
5.5.9
ownCloud version: (see ownCloud admin page)
{"installed":true,"maintenance":false,"version":"8.0.0.1","versionstring":"8.0 alpha 1","edition":""}
Updated from an older ownCloud or fresh install:
fresh
List of activated apps:
none
The content of config/config.php:
Are you using external storage, if yes which one: local/smb/sftp/...
no
Are you using encryption: no
Client configuration
Browser:
Chrome, Firefox
The text was updated successfully, but these errors were encountered: