Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permanent link share privacy warning #27844

Merged
merged 2 commits into from
May 12, 2017
Merged

Add permanent link share privacy warning #27844

merged 2 commits into from
May 12, 2017

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented May 9, 2017

Description

Add permanent link share privacy warning in the share tab view.

Related Issue

https://github.com/owncloud/enterprise/issues/1914

Motivation and Context

Some people want it

How Has This Been Tested?

Open the public link section in the share tab in the sidebar

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81 PVince81 added this to the 10.0.1 milestone May 9, 2017
@PVince81 PVince81 requested review from felixheidecke and pmaier1 May 9, 2017 15:42
@PVince81 PVince81 mentioned this pull request May 9, 2017
Closed
12 tasks
pmaier1
pmaier1 approved these changes May 9, 2017
View reviewed changes
Copy link
Contributor

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the clients there is no 'Warning: ' so for consistency I removed it.

@PVince81 PVince81 force-pushed the share-link-warning branch from 825a510 to f324f5e Compare May 10, 2017 14:47
@PVince81
Copy link
Contributor Author

rebased for CI

@PVince81
Copy link
Contributor Author

So who is going to give a little thumbs up to this ?

@PVince81 PVince81 force-pushed the share-link-warning branch from f324f5e to 78f9ff2 Compare May 12, 2017 08:48
@davitol
Copy link
Contributor

davitol commented May 12, 2017 •
edited
Loading

👍 WFM A warning 'Anyone with the link has access to the file/folder' appears after reloading

@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 343a3ed into master May 12, 2017
@DeepDiver1975 DeepDiver1975 deleted the share-link-warning branch May 12, 2017 09:20
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pmaier1 pmaier1 pmaier1 approved these changes

@felixheidecke felixheidecke Awaiting requested review from felixheidecke

Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
10.0.1
Development

Successfully merging this pull request may close these issues.
4 participants
@PVince81 @davitol @DeepDiver1975 @pmaier1