Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete appstoreurl config value when enabling market #27956

Merged
merged 1 commit into from
May 19, 2017

Conversation

PVince81
Copy link
Contributor

Description

To avoid side effects with old APIs still using it.

Related Issue

Workaround for #27951

How Has This Been Tested?

  1. Setup stable9.1.
  2. Set "appstoreenabled" to "false" in config.php
  3. Upgrade to this branch occ upgrade
  4. Check config.php and see that the value is gone
  5. Install an app with occ market:install guests and see it works

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975

@PVince81
Copy link
Contributor Author

another timeout... rebased

@PVince81 PVince81 merged commit 2cc8475 into master May 19, 2017
@PVince81 PVince81 deleted the appstoreenable-with-market branch May 19, 2017 13:58
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants