Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subadmin cannot disable member of his group #31280

Closed
paurakhsharma opened this issue Apr 26, 2018 · 8 comments
Closed

subadmin cannot disable member of his group #31280

paurakhsharma opened this issue Apr 26, 2018 · 8 comments
Assignees
Milestone

Comments

@paurakhsharma
Copy link
Member

paurakhsharma commented Apr 26, 2018

This works fine using userprovisioning API but it is the case in webUI

Steps to reproduce

  1. As an admin create a new group newgroup
  2. As an admin create new user newuser
  3. As an admin make the newuser subadmin of newgroup
  4. As an admin assign anotheruser to newgroup
  5. As an newuser try to disable anotheruser from newgroup

Expected behaviour

Should be able to disable the user

Actual behaviour

Cannot disable the user

Server configuration

Operating system: 17.10

Web server: Apache

Database: MySQL

PHP version: 7.1

ownCloud version: (see ownCloud admin page) 10.0.8.5

Where did you install ownCloud from: git

Client configuration

Browser:

Operating system:

Logs

Browser log

Request URL: http://localhost/core/index.php/settings/users/user3/enabled
Request Method: POST
Status Code: 403 Forbidden

Screenshot

image

@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #31016 (subadmin should be able to remove users from the group), #20282 (Allow non-admin users to see members of their groups), #31279 (Cannot see members of a group having special characters(@,/,&) in their name), #30558 (FIx wording if you are not a member of any groups), and #30551 (Fix wording if you are not a member of any groups).

@phil-davis
Copy link
Contributor

phil-davis commented Apr 26, 2018

IMO this is a missing feature for sub-admins. A sub-admin can delete any of the users in the group that they manage, so it seems logical that they should be able to do the "lesser" task of disabling a user and enabling them again.

Actually they can do it if they are nerds and sit at a command prompt and do curl commands to the Provisioning API.

This issue is about making it happen for subadmins in the webUI.

@phil-davis
Copy link
Contributor

@paurakhsharma let's look at the current UI tests for the user's page and see how we can extend them to cover more of the "obvious" things that should have basic automated smoke tests.

@phil-davis
Copy link
Contributor

Fixed in core stable10 by #31489
and user_management by owncloud-archive/user_management#30

Leaving this open for making some tests.

@paurakhsharma
Copy link
Member Author

Yes I will look into it after some remaining tests on API sharing

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.)

@phil-davis
Copy link
Contributor

@individual-it you and @paurakhsharma could have a look at how to test this?

@phil-davis
Copy link
Contributor

#33046 implements the test scenario in core stable10.
user_management PR owncloud-archive/user_management#86 implements the scenario or the up-coming user_management app, and skips it because it is currently broken there.

@PVince81 PVince81 modified the milestones: development, QA Jan 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants