Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] remove composer that is now in vendor bin #34418

Merged

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Feb 8, 2019

Description

  - Removing zendframework/zend-eventmanager (3.2.1)
  - Removing zendframework/zend-code (2.6.3)
  - Removing symfony/stopwatch (v3.4.22)
  - Removing symfony/polyfill-php72 (v1.10.0)
  - Removing symfony/options-resolver (v3.4.22)
  - Removing symfony/finder (v3.4.22)
  - Removing symfony/filesystem (v3.4.22)
  - Removing symfony/dom-crawler (v2.8.49)
  - Removing symfony/css-selector (v2.8.49)
  - Removing symfony/browser-kit (v2.8.49)
  - Removing php-cs-fixer/diff (v1.3.0)
  - Removing ocramius/proxy-manager (1.0.2)
  - Removing instaclick/php-webdriver (1.4.5)
  - Removing friendsofphp/php-cs-fixer (v2.14.0)
  - Removing fabpot/goutte (v2.0.4)
  - Removing composer/xdebug-handler (1.3.1)
  - Removing behat/transliterator (v1.2.0)
  - Removing behat/mink-browserkit-driver (1.3.3)
  - Removing behat/mink (v1.7.1)
  - Removing behat/gherkin (v4.6.0)

Now when I do composer update it just says:

composer update
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
  - Updating phpseclib/phpseclib (2.0.13 => 2.0.14): Loading from cache

and that is PR #34285 which is waiting for review.

Note: this is on top of other composer PRs to stable10 that are waiting for CI to finish and be merged.

Related Issue

#33914 issue about moving behat to vendor-bin
#34219 initial move of behat to vendor-bin in stable10 - it did not sort out all the other pieces here
#34212 move of behat to vendor-bin in master

Motivation and Context

Sort this out properly in stable10 now that it is open for change again.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #34418 into stable10 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34418      +/-   ##
==============================================
- Coverage        63.5%    63.5%   -0.01%     
  Complexity      19140    19140              
==============================================
  Files            1265     1265              
  Lines           75285    75297      +12     
  Branches         1291     1291              
==============================================
+ Hits            47810    47817       +7     
- Misses          27095    27100       +5     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.59% <ø> (-0.01%) 19140 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
status.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
lib/private/Console/Application.php 0% <0%> (ø) 19% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.57% <0%> (+0.01%) 105% <0%> (ø) ⬇️
lib/private/Files/Node/AbstractNode.php 98.21% <0%> (+0.03%) 28% <0%> (ø) ⬇️
...eratedfilesharing/lib/Controller/OcmController.php 66.26% <0%> (+0.2%) 30% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️
apps/encryption/lib/Session.php 100% <0%> (+1.96%) 22% <0%> (ø) ⬇️
apps/encryption/templates/settings-admin.php 94.11% <0%> (+5.88%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2374c5...c86a0a9. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 8, 2019

Codecov Report

Merging #34418 into stable10 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34418      +/-   ##
==============================================
- Coverage        63.5%    63.5%   -0.01%     
  Complexity      19140    19140              
==============================================
  Files            1265     1265              
  Lines           75285    75297      +12     
  Branches         1291     1291              
==============================================
+ Hits            47810    47817       +7     
- Misses          27095    27100       +5     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.32% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.59% <ø> (-0.01%) 19140 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
status.php 0% <0%> (ø) 0% <0%> (ø) ⬇️
lib/private/Console/Application.php 0% <0%> (ø) 19% <0%> (ø) ⬇️
lib/private/Files/Cache/Cache.php 97.57% <0%> (+0.01%) 105% <0%> (ø) ⬇️
lib/private/Files/Node/AbstractNode.php 98.21% <0%> (+0.03%) 28% <0%> (ø) ⬇️
...eratedfilesharing/lib/Controller/OcmController.php 66.26% <0%> (+0.2%) 30% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️
apps/encryption/lib/Session.php 100% <0%> (+1.96%) 22% <0%> (ø) ⬇️
apps/encryption/templates/settings-admin.php 94.11% <0%> (+5.88%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2374c5...c86a0a9. Read the comment docs.

@phil-davis phil-davis merged commit 5c9acc4 into stable10 Feb 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-remove-composer-that-is-now-in-vendor-bin branch February 8, 2019 05:25
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants