Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable10] log wrapped exceptions #34475

Merged
merged 1 commit into from
Feb 13, 2019
Merged

[stable10] log wrapped exceptions #34475

merged 1 commit into from
Feb 13, 2019

Conversation

butonic
Copy link
Member

@butonic butonic commented Feb 13, 2019

backport of #32513 to stable10

@butonic
log previous exceptions
a4e19d6 
Exceptions in logs are the only thing we see in bug reports. Wouldn't it be great to also see the previous exceptions?
@butonic butonic requested a review from PVince81 February 13, 2019 08:50
@butonic butonic changed the title log previous exceptions [stable10] log wrapped exceptions Feb 13, 2019
PVince81
PVince81 approved these changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added this to the development milestone Feb 13, 2019
@PVince81
Copy link
Contributor

failure is PHP segfault after success

@PVince81 PVince81 merged commit e873da8 into stable10 Feb 13, 2019
@PVince81 PVince81 deleted the stable10-log-previous-exceptions branch February 13, 2019 11:46
@phil-davis phil-davis mentioned this pull request Mar 9, 2019
Merged
9 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

Assignees
No one assigned
Labels
4 - To release
Projects
None yet
Milestone
development
Development

Successfully merging this pull request may close these issues.
2 participants
@butonic @PVince81