[Stable10] only parse info.xml once #34482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
VicDeo
force-pushed
the
stable10-only-parse-info.xml-once
branch
from
e37c8a2 to
ebc3f04
Compare
delete-merged-branch
bot
deleted the
stable10-only-parse-info.xml-once
branch
|
omg finally \o/ |
This was referenced Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #30188
I was profiling the preview stuff and noticed that we are parsing all info.xml files twice per request.
Top left: current state
Top rigth: cache in local variable per request for file as well.
Bottom left: This PR, cold cache
Bottom right: cached info.xml
x6 speed increase
Related: #30190