Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] reduce query size by properly reusing the query builder #34915

Merged
merged 1 commit into from
Mar 29, 2019

Conversation

butonic
Copy link
Member

@butonic butonic commented Mar 28, 2019

backport of #34906

@codecov
Copy link

codecov bot commented Mar 28, 2019

Codecov Report

Merging #34915 into stable10 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #34915   +/-   ##
===========================================
  Coverage       64.23%   64.23%           
  Complexity      19905    19905           
===========================================
  Files            1277     1277           
  Lines           76277    76277           
  Branches         1292     1292           
===========================================
  Hits            48993    48993           
  Misses          26905    26905           
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.39% <100%> (ø) 19905 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
...ederatedfilesharing/lib/FederatedShareProvider.php 61.13% <100%> (ø) 85 <0> (ø) ⬇️
lib/private/Share20/DefaultShareProvider.php 98.33% <100%> (ø) 114 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985dc97...5b57a61. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 6e677d7 into stable10 Mar 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport/34906 branch March 29, 2019 08:30
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants