Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] group shares should respect to users auto accept choice #34934

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

karakayasemi
Copy link
Contributor

Backport of #34850

Description

If auto accept enabled by admin and if it is a group share, create sub-share for auto accept disabled users in the pending state to respect users auto accept preference.

Related Issue

Fixes #34705

Motivation and Context

Removing bug.

How Has This Been Tested?

  • Enable auto-accept share in the admin sharing panel
  • Create testuser and testgroup.
  • add testuser to testgroup
  • login with test-user and disable auto-accept share from the personal panel
  • share a file to testgroup with admin user
  • the share should be created in pending status for testuser

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit cb8381d into stable10 Apr 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport-34850 branch April 1, 2019 08:45
@lock lock bot locked as resolved and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants