-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.2.0] Respect 'writable' appdir flag on update #35097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35097 +/- ##
====================================================
+ Coverage 64.29% 64.3% +0.01%
- Complexity 20044 20049 +5
====================================================
Files 1285 1285
Lines 76846 76854 +8
Branches 1307 1307
====================================================
+ Hits 49410 49423 +13
+ Misses 27055 27050 -5
Partials 381 381
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Backport of #35072
Description
Check if the current appdir is marked as writable before updating the app
Related Issue
Motivation and Context
Fix App is updated inside the directory that is marked as not writable.
How Has This Been Tested?
see #35031
Types of changes
Checklist: