[10.2.0] Backport of Aborted uploads are not cleared properly #35134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File uploads should also be checked if they are aborted or not. This would help to check if the file is aborted or not. If aborted then it would be cleared from the list. Signed-off-by: Sujith H <[email protected]>
11 tasks
|
Original PR: #35130 |
PVince81
changed the title
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35134 +/- ##
=================================================
Coverage 64.38% 64.38%
Complexity 20049 20049
=================================================
Files 1285 1285
Lines 76851 76851
Branches 1308 1308
=================================================
Hits 49478 49478
Misses 26989 26989
Partials 384 384
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35134 +/- ##
=================================================
Coverage 64.38% 64.38%
Complexity 20049 20049
=================================================
Files 1285 1285
Lines 76851 76851
Branches 1308 1308
=================================================
Hits 49478 49478
Misses 26989 26989
Partials 384 384
Continue to review full report at Codecov.
|
delete-merged-branch
bot
deleted the
fix-upload-cancel-issue-release-10.2.0
branch
52 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
File uploads should also be checked if they
are aborted or not. This would help to check
if the file is aborted or not. If aborted then
it would be cleared from the list.
Signed-off-by: Sujith H [email protected]
Description
When user uploads file and then aborts the upload ( the abort is done for the first time ), the global value of
this._uploadsis not updated properly. If the file is aborted, then as of now the state ofuploadispending. And hencethis._uploadswill always have currently aborted upload. So when the user tries to upload a file next time ( say second time ), then the value in thethis_uploadmismatches. Because it has previous value. And the error could also be seen in the console.In this change set I have introduced an attribute
abortedfor theupload. When the upload is aborted,abortedattribute ofuploadis set to true. And hence while clearing the uploads, it checks whether the current aborted upload should be added to remaining uploads or not.In simple terms its an issue of not clearing uploads list.
Related Issue
Motivation and Context
The aborted upload(s) should be cleared from the list.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: