Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escape t() variables by default #9046

Closed
MorrisJobke opened this issue Jun 16, 2014 · 3 comments · Fixed by #12687
Closed

escape t() variables by default #9046

MorrisJobke opened this issue Jun 16, 2014 · 3 comments · Fixed by #12687
Labels
3 - To Review enhancement junior job security technical debt Type:Bug
Milestone
8.0

Comments

@MorrisJobke
Copy link
Contributor

The escapeHTML() should be called while replacing the variables in t() and shouldn't be done in following way.

t('files_sharing', 'Shared by {owner}', {owner: escapeHTML(fileData.shareOwner)})

cc @LukasReschke @PVince81
@MorrisJobke MorrisJobke mentioned this issue Jun 16, 2014
Merged
@MorrisJobke
Copy link
Contributor Author

spotted here: #9040 (comment)

@MorrisJobke MorrisJobke added this to the ownCloud 8 milestone Jun 16, 2014
PVince81 referenced this issue Jun 17, 2014
@icewind1991
organize js a bit better
2219087
@LukasReschke LukasReschke mentioned this issue Aug 29, 2014
Merged
@karlitschek
Copy link
Contributor

@MorrisJobke can you fix that?

@MorrisJobke
Copy link
Contributor Author

@karlitschek Sure

@MorrisJobke MorrisJobke self-assigned this Dec 6, 2014
@MorrisJobke MorrisJobke modified the milestones: 8.0-current, ownCloud 8 Dec 6, 2014
@MorrisJobke MorrisJobke mentioned this issue Dec 8, 2014
Merged
@MorrisJobke MorrisJobke removed their assignment Oct 5, 2015
@ownclouders ownclouders mentioned this issue Aug 20, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
3 - To Review enhancement junior job security technical debt Type:Bug
Projects
None yet
Milestone
8.0
Development

Successfully merging a pull request may close this issue.

Auto escape t placeholders owncloud/core
4 participants
@MorrisJobke @karlitschek @LukasReschke @butonic