-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow admin to blacklist groups for the files_sharing app #288
Comments
core PR got merged, documentation needs to be created ! |
You are welcome to create it :) Read the PR - no info how to use it. My question is as always - what needs to be documented? Link to PR is not sufficient @jvillafanez |
The waiting for PR label was accidentially removed, stable10 is still open |
I'd prefer not to provide information unless the feature needs it. I usually include some information if the behaviour might be confusing or if there are some problematic scenarios, but this isn't the case. The feature should be easy to use. If you have doubts, feel free to ask: we'll likely need to add documentation for that.
At least basic stuff: that the feature is there, how you can configure it, what is expected to happen... other than that, play with it and check if there is anything that might need to clarify.
Is this clear enough, or do we need to provide an example in the docs? |
Any example that helps making the use more clear is always a good thing. |
Does that help? Real Use Case
|
@mic thanks. This helps. @jvillafanez @mmattel this is the documentation repo, not the "here, we have something new. You figure out how to deal with it and document it while you are doing it"- repo. Putting a little effort in describing your new feature that you want / you need to be documented goes a long way. |
Core:
owncloud/core#31672 (Allow admin to blacklist groups for the files_sharing app)
--> merged
owncloud/core#31740 ([stable10] Sharing blacklist groups stable10)
--> open
It is something that is shown on the settings panel
(apps/files_sharing/lib/Panels/Admin/SettingsPanel.php)
and
(apps/files_sharing/templates/settings.php)
Quote:
This new info should be described in the panel documentation.
The text was updated successfully, but these errors were encountered: