Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admin to blacklist groups for the files_sharing app #288

Closed
mmattel opened this issue Jun 11, 2018 · 8 comments
Closed

Allow admin to blacklist groups for the files_sharing app #288

mmattel opened this issue Jun 11, 2018 · 8 comments
Assignees
Milestone

Comments

@mmattel
Copy link
Contributor

mmattel commented Jun 11, 2018

Core:
owncloud/core#31672 (Allow admin to blacklist groups for the files_sharing app)
--> merged
owncloud/core#31740 ([stable10] Sharing blacklist groups stable10)
--> open

It is something that is shown on the settings panel
(apps/files_sharing/lib/Panels/Admin/SettingsPanel.php)
and
(apps/files_sharing/templates/settings.php)

Quote:

These groups will not receive shares. 
Members of the group can still send and receive shares outside of the group

This new info should be described in the panel documentation.

@mmattel
Copy link
Contributor Author

mmattel commented Jun 29, 2018

core PR got merged, documentation needs to be created !

@settermjd settermjd removed their assignment Jul 2, 2018
@voroyam
Copy link
Contributor

voroyam commented Jul 12, 2018

documentation needs to be created !

You are welcome to create it :)

Read the PR - no info how to use it.

My question is as always - what needs to be documented?

Link to PR is not sufficient @jvillafanez

@mmattel
Copy link
Contributor Author

mmattel commented Jul 13, 2018

The waiting for PR label was accidentially removed, stable10 is still open

@jvillafanez
Copy link
Member

Read the PR - no info how to use it.

I'd prefer not to provide information unless the feature needs it. I usually include some information if the behaviour might be confusing or if there are some problematic scenarios, but this isn't the case.

The feature should be easy to use. If you have doubts, feel free to ask: we'll likely need to add documentation for that.

My question is as always - what needs to be documented?

At least basic stuff: that the feature is there, how you can configure it, what is expected to happen... other than that, play with it and check if there is anything that might need to clarify.

These groups will not receive shares.
Members of the group can still send and receive shares outside of the group

Is this clear enough, or do we need to provide an example in the docs?

@mmattel
Copy link
Contributor Author

mmattel commented Jul 18, 2018

Any example that helps making the use more clear is always a good thing.

@settermjd settermjd transferred this issue from owncloud-archive/documentation Nov 19, 2018
@micbar
Copy link
Contributor

micbar commented Mar 4, 2019

screenshot_2019-03-04 settings - owncloud enterprise edition 1

Does that help?
We need to document this.

Real Use Case

  1. You are using the guest app
  2. You don't want users to share something with the guest group (which are usually external users)
  3. Add guest_app to the sharing blacklist
  4. Sharing to the guest_app group will not be possible, while sharing to other groups and Users, even if they are members of the blacklisted group will continue to be possible.

screenshot_2019-03-04 settings - owncloud enterprise edition 1

screenshot_2019-03-04 settings - owncloud enterprise edition 3

@settermjd settermjd added this to the Backlog milestone May 21, 2019
@micbar micbar modified the milestone: Backlog Jul 26, 2019
@voroyam
Copy link
Contributor

voroyam commented Aug 14, 2019

@mic thanks. This helps.

@jvillafanez @mmattel this is the documentation repo, not the "here, we have something new. You figure out how to deal with it and document it while you are doing it"- repo.

Putting a little effort in describing your new feature that you want / you need to be documented goes a long way.

@voroyam voroyam self-assigned this Aug 14, 2019
@voroyam voroyam closed this as completed Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants