Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/l10n #323

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Bugfix/l10n #323

merged 2 commits into from
Mar 13, 2020

Conversation

DeepDiver1975
Copy link
Member

No description provided.

@DeepDiver1975 DeepDiver1975 requested a review from ChrisEdS March 12, 2020 15:45
@DeepDiver1975 DeepDiver1975 self-assigned this Mar 12, 2020
ChrisEdS
ChrisEdS approved these changes Mar 12, 2020
View reviewed changes
Copy link

@ChrisEdS ChrisEdS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and fast.

@DeepDiver1975
Copy link
Member Author

failing tests can be ignores - random 🤷‍♂️

@DeepDiver1975 DeepDiver1975 merged commit d9ec110 into master Mar 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/l10n branch March 13, 2020 10:30
@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/files_primary_s3/1570/129/17
Annoying - I thought that yesterday I made drone ignore failure of that cleanup-scality-bucket step - it is just a "best effort" cleanup on the way out. Maybe this PR was not rebased to the current latest master.

@DeepDiver1975
Copy link
Member Author

Maybe this PR was not rebased to the current latest master.

highly possible. in any case: thx a lot

@davitol davitol mentioned this pull request Apr 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisEdS ChrisEdS ChrisEdS approved these changes

Assignees

@DeepDiver1975 DeepDiver1975

Labels
3 - To review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeepDiver1975 @phil-davis @ChrisEdS