Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1.2] Add l10n to dist/appstore build #340

Merged
merged 7 commits into from
Apr 22, 2020
Merged

[release-1.1.2] Add l10n to dist/appstore build #340

merged 7 commits into from
Apr 22, 2020

Conversation

phil-davis
Copy link
Contributor

So that translations end up in the released app.

@phil-davis phil-davis requested a review from davitol April 21, 2020 08:39
@phil-davis phil-davis self-assigned this Apr 21, 2020
@phil-davis
Copy link
Contributor Author

In other apps we put both README.md and CHANGELOG.md into the released app.
But in this app there is only CHANGELOG.md
Should we add README.md also?

@phil-davis
Copy link
Contributor Author

CI failed because core master has dropped PHP 7.1.
I cherry-picked commits from master for:

  • a couple of other transifex translation updates
  • the various CI-related changes from master that were not yet in the release branch.

Let's see if it passes...

@phil-davis phil-davis merged commit d88705a into release-1.1.2 Apr 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the add-l10n-to-build branch April 22, 2020 03:20
This was referenced Apr 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

@davitol davitol Awaiting requested review from davitol

Assignees

@phil-davis phil-davis

Labels
4 - To release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-davis @DeepDiver1975 @dpakach