Updating dependency

[SergioBertolinSG]

Updating endroid/qrcode 1.6.6 deprecated to endroid/qr-code 2.5.0 (newest version available for php 5.6)

There are failures regarding this update:

{"reqId":"qztHBxaw9utLihGhbrWq","level":3,"time":"2018-01-12T13:35:55+00:00","remoteAddr":"85.57.168.79","user":"talion","app":"index","method":"POST","url":"\/index.php\/apps\/twofactor_totp\/settings\/enable","message":"Exception: {\"Exception\":\"Error\",\"Message\":\"Call to undefined method Endroid\\\\QrCode\\\\QrCode::getDataUri()\",\"Code\":0,\"Trace\":\"#0 [internal function]: OCA\\\\TwoFactor_Totp\\\\Controller\\\\SettingsController->enable(true)\\n#1 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Http\\\/Dispatcher.php(159): call_user_func_array(Array, Array)\\n#2 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Http\\\/Dispatcher.php(89): OC\\\\AppFramework\\\\Http\\\\Dispatcher->executeController(Object(OCA\\\\TwoFactor_Totp\\\\Controller\\\\SettingsController), 'enable')\\n#3 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/App.php(103): OC\\\\AppFramework\\\\Http\\\\Dispatcher->dispatch(Object(OCA\\\\TwoFactor_Totp\\\\Controller\\\\SettingsController), 'enable')\\n#4 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/AppFramework\\\/Routing\\\/RouteActionHandler.php(46): OC\\\\AppFramework\\\\App::main('OCA\\\\\\\\TwoFactor_T...', 'enable', Object(OC\\\\AppFramework\\\\DependencyInjection\\\\DIContainer), Array)\\n#5 [internal function]: OC\\\\AppFramework\\\\Routing\\\\RouteActionHandler->__invoke(Array)\\n#6 \\\/opt\\\/owncloud\\\/lib\\\/private\\\/Route\\\/Router.php(342): call_user_func(Object(OC\\\\AppFramework\\\\Routing\\\\RouteActionHandler), Array)\\n#7 \\\/opt\\\/owncloud\\\/lib\\\/base.php(913): OC\\\\Route\\\\Router->match('\\\/apps\\\/twofactor...')\\n#8 \\\/opt\\\/owncloud\\\/index.php(55): OC::handleRequest()\\n#9 {main}\",\"File\":\"\\\/opt\\\/owncloud\\\/apps\\\/twofactor_totp\\\/lib\\\/Controller\\\/SettingsController.php\",\"Line\":84}"}

[DeepDiver1975]

There are failures regarding this update:

well - the api changed obviously ....

[SergioBertolinSG]

This update is mandatory for this app or can be released with this library deprecated?

[karakayasemi]

I can take a look to fix the problems. if you want, you can assign this issue to me.

[SergioBertolinSG]

@karakayasemi thanks, all yours.

This will be included in 0.4.5 release. (Next one is 0.4.4).

[PVince81]

any update ? still WIP ?

[karakayasemi]

Nope, all tests are passing, it is ready to merge.

[phil-davis]

I added QA-team label here, because I will likely come across stuff like this as I standardize CI-drone-Makefile-test scripts.

But actually it looks like this could be merged anyway? @DeepDiver1975

[karakayasemi]

Since the current version of this dependency deprecated, IMHO this change mandatory. There was a dependabot pr for the same dependency #47. I closed it regarding this PR.

[PVince81]

Yeah, let's merge 👍

[PVince81]

hmm, so the test failures just disappeared??

[karakayasemi]

hmm, so the test failures just disappeared??

Yes, I adapted the code to API changes.