Add note about disks to instance delete confirm (#2185)

add note about disks to instance delete confirm
oxidecomputer · Apr 23, 2024 · 2b6d0f7 · 2b6d0f7
1 parent e649e7b
commit 2b6d0f7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/app/pages/project/instances/actions.tsx b/app/pages/project/instances/actions.tsx
@@ -129,6 +129,7 @@ export const useMakeInstanceActions = (
               }),
             label: instance.name,
             resourceKind: 'instance',
+            extraContent: 'Any attached disks will be detached but not deleted.',
           }),
           disabled: !instanceCan.delete(instance) && (
             <>Only {fancifyStates(instanceCan.delete.states)} instances can be deleted</>

diff --git a/app/stores/confirm-delete.tsx b/app/stores/confirm-delete.tsx
@@ -24,17 +24,22 @@ type DeleteConfig = {
    */
   label: React.ReactNode
   resourceKind?: string
+  extraContent?: React.ReactNode
 }
 
 export const confirmDelete =
-  ({ doDelete, label, resourceKind }: DeleteConfig) =>
+  ({ doDelete, label, resourceKind, extraContent }: DeleteConfig) =>
   () => {
     const displayLabel = typeof label === 'string' ? <HL>{label}</HL> : label
     const modalTitle = resourceKind ? `Confirm delete ${resourceKind}` : 'Confirm delete'
     useConfirmAction.setState({
       actionConfig: {
         doAction: doDelete,
-        modalContent: <p>Are you sure you want to delete {displayLabel}?</p>,
+        modalContent: (
+          <p>
+            Are you sure you want to delete {displayLabel}? {extraContent}
+          </p>
+        ),
         errorTitle: 'Could not delete resource',
         modalTitle,
         actionType: 'danger',