Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance delete confirm modal: say disks will be detached but not deleted #2150

Closed
david-crespo opened this issue Apr 15, 2024 · 0 comments · Fixed by #2185
Closed

Instance delete confirm modal: say disks will be detached but not deleted #2150

david-crespo opened this issue Apr 15, 2024 · 0 comments · Fixed by #2185
Labels
Milestone

Comments

@david-crespo
Copy link
Collaborator

david-crespo commented Apr 15, 2024

  1. Say "instance db1", we do that elsewhere and I think it's nice
  2. Say something like "Attached disks will be detached, but they are not automatically deleted."
  3. We could list the disks right in the modal, but it would require an additional fetch and I think there are rapidly diminishing returns to figuring out how to display some arbitrarily long list of disk names
  4. We could theoretically mention other things that will or won't be deleted: ephemeral IPs will, NICs will, floating IPs won't. Bit of a design question to jam all that into the modal, but I think it could be helpful.
image
@david-crespo david-crespo added this to the 8 milestone Apr 15, 2024
@david-crespo david-crespo changed the title Instance delete confirm modal: say disks will be detached but not deleted in Instance delete confirm modal: say disks will be detached but not deleted Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant