Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blueprint-execution: Remove step that plumbs firewall rules #7525

Open
jgallagher opened this issue Feb 12, 2025 · 0 comments
Open

blueprint-execution: Remove step that plumbs firewall rules #7525

jgallagher opened this issue Feb 12, 2025 · 0 comments

Comments

@jgallagher
Copy link
Contributor

When this step was added to blueprint execution, it was required so sled-agent could get firewall rules for newly-deployed Nexus instances. Since then, the ServiceRulePropagator RPW has been added, which plumbs firewall rules periodically.

I think it would be fine to just delete the blueprint execution step entirely, but needs at least some basic testing to ensure that's right. The activation period for ServiceRulePropagator is currently pretty long (5 minutes), so there might be cases for:

  • shorten the ServiceRulePropagator period
  • have blueprint execution activate ServiceRulePropagator explicitly after deploying zones (I think this would be equivalent to the previous bullet? since we'd now be activating ServiceRulePropagator on the blueprint-execution period)
  • have blueprint execution activate ServiceRulePropagator explicitly after deploying zones if any new zones were added (I think this would require more information from sled-agent about what it did to handle a PUT /omicron-zones request)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant