Implementing StableApiDefinition RBasic methods for TruffleRuby. #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goyox86
commented
Dec 2, 2024
goyox86
changed the title
ianks
reviewed
Dec 4, 2024
ianks
reviewed
Dec 4, 2024
ianks
reviewed
Dec 4, 2024
…ing instead of fcalls
goyox86
force-pushed
the
goyox86/stable-api-rbasic-methods
branch
from
d3b8a64 to
896f547
Compare
|
@ianks Applied the changes (and rebased) I think we should be good now. |
goyox86
changed the title
ianks
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #446
Not sure if calling
rb_obj_frozen_pis correct in the Rust side.Tried to do what MRI does but
ruby_fl_typedoes not seem to be available in bindgen's output.