Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Redis pingInterval to fix Socket Closed exceptions #21

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Added Redis pingInterval to fix Socket Closed exceptions #21

merged 3 commits into from
Sep 4, 2024

Conversation

michaeldisaro
Copy link
Contributor

List of Changes

Added pingInterval to redis client.

Motivation and Context

This should fix the socket closed unexpectedly as reported here redis/node-redis#1598.

How Has This Been Tested?

  • unit tests
  • integration tests
  • build

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@michaeldisaro michaeldisaro requested a review from a team as a code owner September 4, 2024 13:11
@lucacavallaro lucacavallaro self-requested a review September 4, 2024 13:13
lucacavallaro
lucacavallaro reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@lucacavallaro lucacavallaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but make sure that this redis module is configured by all the best practices that we use in other projects

@michaeldisaro michaeldisaro merged commit 2b55a73 into main Sep 4, 2024
5 checks passed
@michaeldisaro michaeldisaro deleted the fix-redis-socket-closed branch September 4, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacavallaro lucacavallaro lucacavallaro left review comments

@Garma00 Garma00 Garma00 approved these changes

Assignees
No one assigned
Labels
external-interface-changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaeldisaro @lucacavallaro @Garma00