Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

styles(message): Message component styling RE icon positioning #207

Merged
merged 1 commit into from
Jul 19, 2021
Merged

styles(message): Message component styling RE icon positioning #207

merged 1 commit into from
Jul 19, 2021

Conversation

ChefHutch
Copy link
Contributor

@ChefHutch ChefHutch commented Jul 19, 2021 •
edited
Loading

  • Removed unused & conflicting svg alignSelf styles
  • Wrap icon in Box to make it a block element, defaulting to displaying at the start of the flexed MessageContainer

Design specs for the Message component all look like:
Screenshot 2021-07-19 at 09 57 48

But our previous Message styles apply this:
Screenshot 2021-07-19 at 09 57 14

@ChefHutch ChefHutch changed the title chore(message): Wrap icon in box to apply correct styling styles(message): Message component styling RE icon positioning Jul 19, 2021
@ChefHutch ChefHutch self-assigned this Jul 19, 2021
@hachiojidev hachiojidev merged commit 36a0437 into pancakeswap:master Jul 19, 2021
@ChefHutch ChefHutch deleted the chore/wrap-message-icon-in-div branch July 19, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hachiojidev hachiojidev hachiojidev approved these changes

@Chef-Chungus Chef-Chungus Awaiting requested review from Chef-Chungus

@RabbitDoge RabbitDoge Awaiting requested review from RabbitDoge

Assignees

@ChefHutch ChefHutch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChefHutch @hachiojidev