Make yarn test
fire on pull_request and fix snapshot fail on master
#59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I noticed that a test was failing on
master
. It turns out that thepush
action only seems to run before a branch has been PRed - i.e. - https://github.com/ChefHutch/pancake-toolkit/runs/2295909352 (the first push to this branch before I created the PR).Once PRed, the action doesn't seem to run. Notice CI passes (with a failing test) for every commit in this PR before I add the
on: [... pull_request]
value in e4dd4e7 (at which pointyarn test
fires, and CI fails. Woot!).Code changes
test
action run on pull_request