explicitly pass if version.logger

paper-trail-gem · Dec 5, 2016 · 5207a55 · 5207a55
1 parent 5ec7b00
commit 5207a55
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/paper_trail/record_trail.rb b/lib/paper_trail/record_trail.rb
@@ -502,10 +502,10 @@ def habtm_assoc_ids(habtm_assoc)
     end
 
     def log_version_errors(version, action)
-      (version.logger || Logger.new(STDOUT)).warn(
+      version.logger.warn(
         "Unable to create version for #{action} of #{@record.class.name}" +
           "##{@record.id}: " + version.errors.full_messages.join(", ")
-      )
+      ) if version.logger
     end
 
     # Returns true if the given HABTM association should be saved.

diff --git a/lib/paper_trail/reifier.rb b/lib/paper_trail/reifier.rb
@@ -179,8 +179,8 @@ def reify_attributes(model, version, attrs)
             model[k.to_sym] = v
           elsif model.respond_to?("#{k}=")
             model.send("#{k}=", v)
-          else
-            (version.logger || Logger.new(STDOUT)).warn(
+          elsif version.logger
+            version.logger.warn(
               "Attribute #{k} does not exist on #{version.item_type} (Version id: #{version.id})."
             )
           end