-
Notifications
You must be signed in to change notification settings - Fork 901
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix #501; The check to whether the table exists for association suppo…
…rt should not be inside of a Proc
- Loading branch information
Showing
1 changed file
with
5 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca09a8c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does fix the bug in production, development and most of the tests. But fails on a few request specs that actually depend on paper_trail.
I guess we need to figure out a way to differentiate gem specs from app specs. If I'm understanding this correctly, we need to force association when running gem specs.
However I would argue that the responsibility in that case lies with the one disabling the db, the test setup. Either we can mock
table_exists?
there, or even better wraptable_exists?
in a config option and provide a way to force that. I'm currently on mobile. Will make a pull request later today.