The originator property is improperly cached

[jonkessler]

The originator property is permanently cached on model instances that have paper trails. This breaks the behavior shown in the README. Specifically, this does not work:

>> widget = Widget.find 153                    # assume widget has 0 versions
>> PaperTrail.whodunnit = 'Alice'
>> widget.update_attributes :name => 'Yankee'
>> widget.originator                           # 'Alice'
>> PaperTrail.whodunnit = 'Bob'
>> widget.update_attributes :name => 'Zulu'
>> widget.originator                           # 'Bob'

The last widget.originator returns 'Alice', not 'Bob'. This is because the originator method on models is defined like this in has_paper_trail.rb:

# Returns who put the object into its current state.
def originator
  @originator ||= self.class.paper_trail_version_class.with_item_keys(self.class.base_class.name, id).last.try :whodunnit
end

Because of the '||=' in there, originator will never be recomputed for that particular instance. The caching was added in this commit: 43fdce6. I would suggest that that caching either be removed or be invalidated somehow when the originator has actually changed.

Thanks, and thanks for the good work on the gem.

[batter]

Good call on this, I think it probably makes sense just not to cache it. Let me take a crack at a patch this afternoon.