-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Travis against postgres and mysql. #344
Run Travis against postgres and mysql. #344
Conversation
I believe we'd need to add the |
@batter how do you want me to handle the the rspec test's where you are cloning the sqlite3 db. I am inclined to just spawn db's and rerun migrations for the foo and bar namespace. |
I'm not sure what the best way to handle it is, so you can tackle it whatever way works for you. It's probably not even necessary to run those specs with MySQL or Postgres because they are simply there to demonstrate the ability to use the |
So PG has two transient failing specs that I haven't been able to nail down just yet. SQLITE is still green. As for mysql it looks to be failing due to the timestamp bug, most of the reifies are returning the wrong version. To run tests against a another db
or
|
Accomplished by swapping out database.yml files for the dummy rails instance with en engine specific one.
(Also another static ID)
Changing the test to not use the unsorted with with_item_keys call.
@batter This should be good to merge into mainline, I have compressed all the commits regarding to setting up the environment. Each commit after that is addressing specific issues regarding getting postgres to pass. This should give us good ground to stand on for getting ready to fix MYSQL support. |
@rposborne - Fantastic! Thanks so much for all the hard work on this, I really appreciate it. I'm going to take a closer look later today but at a glance everything looks good for the most part. I'll try to get it merged shortly. |
@batter My pleasure, it's fun to dig into some non client work sometimes! I think it will be much better for the project in the long run testing against the DB's we all use in production. |
Wow, outstanding work. Looks like you even caught an unrelated bug in cb46e87. I'll see if I can write a spec / test for that too. I have no doubt that this will be much better for the project in making sure it is compatible with multiple database types. Thanks again! |
@batter, Thanks for making my day! Glad I could help. |
Allow travis to catch issues such as #314