Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI against rails/master #896

Merged
merged 1 commit into from
Nov 30, 2016

Conversation

sgrif
Copy link
Contributor

@sgrif sgrif commented Nov 30, 2016

This adds Rails master to CI as an allowed failure. While builds will
continue to pass regardless of this run, it makes it easier to keep an
eye on if changes need to be made for the upcoming version of Rails, as
well as automatically test shims to add compatibility

@sgrif
Copy link
Contributor Author

sgrif commented Nov 30, 2016

Ironically, this works even though https://github.com/airblade/paper_trail/blob/6411ab1ce6f661075092d7597d32e4c1f9eae7ff/paper_trail.gemspec#L27 is present because 5.1.0.alpha and any other prerelease version is still considered to be < 5.1

@sgrif sgrif force-pushed the sg-run-master-on-ci branch from 43bc86c to e161613 Compare November 30, 2016 15:53
This adds Rails master to CI as an allowed failure. While builds will
continue to pass regardless of this run, it makes it easier to keep an
eye on if changes need to be made for the upcoming version of Rails, as
well as automatically test shims to add compatibility
@sgrif sgrif force-pushed the sg-run-master-on-ci branch from e161613 to 938361d Compare November 30, 2016 17:20
@jaredbeck
Copy link
Member

I think that #898 might conflict with this. Let's merge this first so we don't have to ask Sean to rebase again and fix a conflict. :)

@jaredbeck jaredbeck merged commit b7da365 into paper-trail-gem:master Nov 30, 2016
@batter
Copy link
Collaborator

batter commented Dec 1, 2016

👍

@sgrif sgrif deleted the sg-run-master-on-ci branch December 2, 2016 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants