Update RSpec matchers to work with custom version association names #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, Esteban! Looks good. Please add a test in |
|
Sure. On it! |
kitop
changed the title
kitop
force-pushed
the
rspec-matchers-custom-association-names
branch
from
97681fc to
1677508
Compare
`have_a_version_with` and `have_a_version_with_changes` had the `versions` association call hardcoded. If `has_paper_trail` had the `versions` option set to something else (e.g: `has_paper_trail versions: :paper_trail_versions`) the matcher couldn't be used. This fixes that issue by dynamically fetching the association name from the `:versions_association_name` class attribute.
kitop
force-pushed
the
rspec-matchers-custom-association-names
branch
from
1677508 to
60847d6
Compare
|
Done, and squashed. |
|
Nice work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
have_a_version_withandhave_a_version_with_changeshad theversionsassociation call hardcoded.If
has_paper_trailhad theversionsoption set to something else(e.g:
has_paper_trail versions: :paper_trail_versions) the matchercouldn't be used.
This fixes that issue by dynamically fetching the association name from
the
:versions_association_nameclass attribute.