Fix tests, and fix error calling private method in rails 4.0 #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It breaks the build because it requires rubocop 0.47, which we have not upgraded to yet. I'm not sure how the addition of rubocop-thread_safety passed CI. I want to try it out, but don't want to upgrade rubocop right now.
Dependency of rubocop-rspec. Again, not sure how the addition of rubocop-rspec passed CI.
There are obviously people still using it, unfortunately. They should update immediately, as AR < 4.2 is EOL, and PT will drop support very soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #929
Anyone using rails 4.0 should upgrade immediately, as rails < 4.2 is EOL and PT will drop support very soon.