Fix ActiveRecord version check in Rails 4.0 #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 4.0 does not have the `ActiveRecord.gem_version` method, so this check will fail there. However, we know that if `gem_version` is not available, we are not dealing with Rails >= 5.0, so this will work in both cases. See paper-trail-gem#956 for an equivalent case elsewhere in the codebase.
magnusvk
added a commit
to magnusvk/counter_culture
that referenced
this pull request
Sep 5, 2017
As they currently fail. We should be able to remove this if paper-trail-gem/paper_trail#988 gets merged.
jaredbeck
requested changes
Sep 5, 2017
There was a problem hiding this comment.
Rails 4.0 does not have the ActiveRecord.gem_version method, so this
check will fail there. However, we know that if gem_version is not
available, we are not dealing with Rails >= 5.0, so this will work in
both cases.
Thanks Magnus. Looks good to me. Please add:
- changelog entry under Unreleased -> Fixed
- comment above conditional explaining that conditional can be deleted when we drop support (soon) for rails < 4.2
|
@jaredbeck added as requested. |
jaredbeck
requested changes
Sep 7, 2017
CHANGELOG.md
Outdated
| @@ -31,6 +31,8 @@ recommendations of [keepachangelog.com](http://keepachangelog.com/). | |||
|
|
|||
| - [#985](https://github.com/airblade/paper_trail/pull/985) - Fix RecordInvalid | |||
| error on nil item association when belongs_to_required_by_default is enabled. | |||
| - [#988](https://github.com/airblade/paper_trail/pull/988) - Fix ActiveRecord | |||
| version check in `VersionConcern` for Rails 4.0 | |||
There was a problem hiding this comment.
Please put your changelog entry under Unreleased -> Fixed. Here you have it under 7.1.2 -> Fixed. Thanks.
|
Oops. @jaredbeck fixed. |
jaredbeck
approved these changes
Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 4.0 does not have the
ActiveRecord.gem_versionmethod, so thischeck will fail there. However, we know that if
gem_versionis notavailable, we are not dealing with Rails >= 5.0, so this will work in
both cases.
See #956 for an equivalent case elsewhere in the codebase.