From 0ee689f3577048bebf3b97d642af69cded17a9c0 Mon Sep 17 00:00:00 2001
From: Dan Cline <6798349+Rjected@users.noreply.github.com>
Date: Thu, 8 Aug 2024 16:45:45 -0400
Subject: [PATCH] fix: detect invalid buffered block when insert fails (#10217)

---
 crates/engine/tree/src/tree/mod.rs | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/crates/engine/tree/src/tree/mod.rs b/crates/engine/tree/src/tree/mod.rs
index fa51dede04ac..9e9a05a8c98c 100644
--- a/crates/engine/tree/src/tree/mod.rs
+++ b/crates/engine/tree/src/tree/mod.rs
@@ -1391,11 +1391,14 @@ where
                 }
                 Err(err) => {
                     debug!(target: "engine", ?err, "failed to connect buffered block to tree");
+                    if let Err(fatal) = self.on_insert_block_error(err) {
+                        warn!(target: "engine", %fatal, "fatal error occurred while connecting buffered blocks");
+                    }
                 }
             }
         }
 
-        debug!(target: "engine", elapsed = ?now.elapsed(), %block_count ,"connected buffered blocks");
+        debug!(target: "engine", elapsed = ?now.elapsed(), %block_count, "connected buffered blocks");
     }
 
     /// Attempts to recover the block's senders and then buffers it.
@@ -1634,6 +1637,9 @@ where
             }
             Err(err) => {
                 debug!(target: "engine", err=%err.kind(), "failed to insert downloaded block");
+                if let Err(fatal) = self.on_insert_block_error(err) {
+                    warn!(target: "engine", %fatal, "fatal error occurred while inserting downloaded block");
+                }
             }
         }
         None