From 36a6437aa84b564fc22fe0359acd736bc4eb823d Mon Sep 17 00:00:00 2001 From: Matthias Seitz Date: Tue, 28 May 2024 19:13:12 +0200 Subject: [PATCH] chore(deps): txpool deps cleanup --- Cargo.lock | 5 +---- crates/transaction-pool/Cargo.toml | 7 +++---- crates/transaction-pool/src/lib.rs | 3 ++- crates/transaction-pool/src/noop.rs | 2 +- crates/transaction-pool/src/pool/mod.rs | 2 +- crates/transaction-pool/src/test_utils/mock.rs | 2 +- crates/transaction-pool/src/traits.rs | 6 ++++-- 7 files changed, 13 insertions(+), 14 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index bd3da5f3fad8..a6bdb5b1c0fd 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -8137,16 +8137,13 @@ dependencies = [ "pprof", "proptest", "rand 0.8.5", - "reth-eth-wire", + "reth-eth-wire-types", "reth-fs-util", "reth-metrics", - "reth-network-types", "reth-primitives", "reth-provider", - "reth-revm", "reth-tasks", "reth-tracing", - "revm", "rustc-hash", "schnellru", "serde", diff --git a/crates/transaction-pool/Cargo.toml b/crates/transaction-pool/Cargo.toml index 82020e17257a..e742c569b76a 100644 --- a/crates/transaction-pool/Cargo.toml +++ b/crates/transaction-pool/Cargo.toml @@ -13,15 +13,14 @@ workspace = true [dependencies] # reth -reth-eth-wire.workspace = true +reth-eth-wire-types.workspace = true reth-primitives.workspace = true reth-fs-util.workspace = true reth-provider.workspace = true reth-tasks.workspace = true -revm.workspace = true + +# ethereum alloy-rlp.workspace = true -reth-revm = { workspace = true, optional = true } -reth-network-types.workspace = true # async/futures futures-util.workspace = true diff --git a/crates/transaction-pool/src/lib.rs b/crates/transaction-pool/src/lib.rs index 45ab93444e7a..0ddc8ec016fc 100644 --- a/crates/transaction-pool/src/lib.rs +++ b/crates/transaction-pool/src/lib.rs @@ -147,11 +147,12 @@ issue_tracker_base_url = "https://github.com/paradigmxyz/reth/issues/" )] #![cfg_attr(docsrs, feature(doc_cfg, doc_auto_cfg))] +#![cfg_attr(not(test), warn(unused_crate_dependencies))] #![warn(clippy::missing_const_for_fn)] use crate::{identifier::TransactionId, pool::PoolInner}; use aquamarine as _; -use reth_eth_wire::HandleMempoolData; +use reth_eth_wire_types::HandleMempoolData; use reth_primitives::{Address, BlobTransactionSidecar, PooledTransactionsElement, TxHash, U256}; use reth_provider::StateProviderFactory; use std::{collections::HashSet, sync::Arc}; diff --git a/crates/transaction-pool/src/noop.rs b/crates/transaction-pool/src/noop.rs index b550a2bc160c..8c3a52f4c348 100644 --- a/crates/transaction-pool/src/noop.rs +++ b/crates/transaction-pool/src/noop.rs @@ -16,7 +16,7 @@ use crate::{ PooledTransactionsElement, PropagatedTransactions, TransactionEvents, TransactionOrigin, TransactionPool, TransactionValidationOutcome, TransactionValidator, ValidPoolTransaction, }; -use reth_eth_wire::HandleMempoolData; +use reth_eth_wire_types::HandleMempoolData; use reth_primitives::{Address, BlobTransactionSidecar, TxHash, U256}; use std::{collections::HashSet, marker::PhantomData, sync::Arc}; use tokio::sync::{mpsc, mpsc::Receiver}; diff --git a/crates/transaction-pool/src/pool/mod.rs b/crates/transaction-pool/src/pool/mod.rs index 163f30ea6b49..fe84e6e90b0b 100644 --- a/crates/transaction-pool/src/pool/mod.rs +++ b/crates/transaction-pool/src/pool/mod.rs @@ -82,7 +82,7 @@ use crate::{ }; use best::BestTransactions; use parking_lot::{Mutex, RwLock, RwLockReadGuard}; -use reth_eth_wire::HandleMempoolData; +use reth_eth_wire_types::HandleMempoolData; use reth_primitives::{ Address, BlobTransaction, BlobTransactionSidecar, IntoRecoveredTransaction, PooledTransactionsElement, TransactionSigned, TxHash, B256, diff --git a/crates/transaction-pool/src/test_utils/mock.rs b/crates/transaction-pool/src/test_utils/mock.rs index dded89a0ed6f..15755b4e602f 100644 --- a/crates/transaction-pool/src/test_utils/mock.rs +++ b/crates/transaction-pool/src/test_utils/mock.rs @@ -760,7 +760,7 @@ impl EthPoolTransaction for MockTransaction { fn validate_blob( &self, _blob: &BlobTransactionSidecar, - _settings: &revm::primitives::KzgSettings, + _settings: &reth_primitives::kzg::KzgSettings, ) -> Result<(), reth_primitives::BlobTransactionValidationError> { match &self { Self::Eip4844 { .. } => Ok(()), diff --git a/crates/transaction-pool/src/traits.rs b/crates/transaction-pool/src/traits.rs index fba43e899c20..dd465a77b9ff 100644 --- a/crates/transaction-pool/src/traits.rs +++ b/crates/transaction-pool/src/traits.rs @@ -8,8 +8,7 @@ use crate::{ AllTransactionsEvents, }; use futures_util::{ready, Stream}; -use reth_eth_wire::HandleMempoolData; -use reth_network_types::PeerId; +use reth_eth_wire_types::HandleMempoolData; use reth_primitives::{ kzg::KzgSettings, transaction::TryFromRecoveredTransactionError, AccessList, Address, BlobTransactionSidecar, BlobTransactionValidationError, FromRecoveredPooledTransaction, @@ -29,6 +28,9 @@ use std::{ }; use tokio::sync::mpsc::Receiver; +/// The PeerId type. +pub type PeerId = reth_primitives::B512; + /// General purpose abstraction of a transaction-pool. /// /// This is intended to be used by API-consumers such as RPC that need inject new incoming,