From 4139d00afef9a187680c976943e99eb54c2dbbab Mon Sep 17 00:00:00 2001 From: Alexey Shekhirin Date: Tue, 17 Sep 2024 11:09:57 +0100 Subject: [PATCH] add empty tests for remaining cases --- crates/exex/exex/src/manager.rs | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/crates/exex/exex/src/manager.rs b/crates/exex/exex/src/manager.rs index bf5e7c86819b..5e0e5b215cd6 100644 --- a/crates/exex/exex/src/manager.rs +++ b/crates/exex/exex/src/manager.rs @@ -1301,6 +1301,12 @@ mod tests { Ok(()) } + #[ignore] + #[tokio::test] + async fn exex_notifications_behind_head_non_canonical() -> eyre::Result<()> { + Ok(()) + } + #[tokio::test] async fn exex_notifications_same_head_canonical() -> eyre::Result<()> { let provider_factory = create_test_provider_factory(); @@ -1345,13 +1351,19 @@ mod tests { notifications_rx, ) .with_head(exex_head); - let new_notification = notifications.next().await.transpose()?; + let new_notification = notifications.next().await.transpose()?; assert_eq!(new_notification, Some(notification)); Ok(()) } + #[ignore] + #[tokio::test] + async fn exex_notifications_same_head_non_canonical() -> eyre::Result<()> { + Ok(()) + } + #[tokio::test] async fn test_notifications_ahead_of_head() -> eyre::Result<()> { let mut rng = generators::rng(); @@ -1403,6 +1415,8 @@ mod tests { let new_notification = poll_fn(|cx| Poll::Ready(notifications.poll_next_unpin(cx))).await; assert!(new_notification.is_pending()); + // Imitate the node catching up with the ExEx by sending a notification for the missing + // block let notification = ExExNotification::ChainCommitted { new: Arc::new(Chain::new( vec![random_block(