Properly bubble up InsertBlockFatalError

[Rjected]

ref #10217 (review)

We need to introduce a way to handle any fatal errors that were encountered when calling insert_block.

This happens in two places not already handled, first in on_downloaded_block:

reth/crates/engine/tree/src/tree/mod.rs

Lines 1638 to 1643 in 0ee689f

	Err(err) => {
	debug!(target: "engine", err=%err.kind(), "failed to insert downloaded block");
	if let Err(fatal) = self.on_insert_block_error(err) {
	warn!(target: "engine", %fatal, "fatal error occurred while inserting downloaded block");
	}
	}

And in try_connect_buffered_blocks:

reth/crates/engine/tree/src/tree/mod.rs

Lines 1394 to 1396 in 0ee689f

	if let Err(fatal) = self.on_insert_block_error(err) {
	warn!(target: "engine", %fatal, "fatal error occurred while connecting buffered blocks");
	}

on_backfill_sync_finished calls try_connect_buffered_blocks here:

reth/crates/engine/tree/src/tree/mod.rs

Line 502 in 0ee689f

self.on_engine_message(msg);

The other call to try_connect_buffered_blocks is here:

reth/crates/engine/tree/src/tree/mod.rs

Line 1628 in 0ee689f

self.try_connect_buffered_blocks(block_num_hash);

However, we need to bubble the error in this method anyways or include it in TreeEvent somehow, because we call insert_block here and need to handle the error:

reth/crates/engine/tree/src/tree/mod.rs

Lines 1638 to 1643 in 0ee689f

	Err(err) => {
	debug!(target: "engine", err=%err.kind(), "failed to insert downloaded block");
	if let Err(fatal) = self.on_insert_block_error(err) {
	warn!(target: "engine", %fatal, "fatal error occurred while inserting downloaded block");
	}
	}

[martinezjorge]

Is anyone on this? Could I take a stab at it?

[Rjected]

Is anyone on this? Could I take a stab at it?

assigned! let me know if you have any questions or need review

[rkrasiuk]

@Rjected emitting a fatal event is not ideal. we should properly bubble it up. @martinezjorge feel free to change the return types of methods in the flow in question