Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev ChainOrchestrator / Service #10714

Closed
Tracked by #9554
mattsse opened this issue Sep 5, 2024 · 1 comment · Fixed by #10803
Closed
Tracked by #9554

Add dev ChainOrchestrator / Service #10714

mattsse opened this issue Sep 5, 2024 · 1 comment · Fixed by #10803
Assignees
Labels
C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Sep 5, 2024

Describe the feature

for #7131 we need dev version of

// Configure the consensus engine
let mut eth_service = EngineService::new(
ctx.consensus(),
ctx.components().block_executor().clone(),
ctx.chain_spec(),
network_client.clone(),
Box::pin(consensus_engine_stream),
pipeline,
Box::new(ctx.task_executor().clone()),
ctx.provider_factory().clone(),
ctx.blockchain_db().clone(),
pruner,
ctx.components().payload_builder().clone(),
TreeConfig::default(),
ctx.invalid_block_hook()?,
);

the thing that drives the chain forward, for dev mode, this is similar to the

pub struct MiningTask<Client, Pool: TransactionPool, Executor, Engine: EngineTypes> {

but acts similar to:

pub struct EngineApiTreeHandler<P, E, T: EngineTypes> {
or rather the persistence stuff

like a task that polls a local payload builder based on some mining mode and appends a new block

All of this should go into a new crate under engine, this should reuse the payload builder stack and not roll custom block building like the auto-seal-consensus does

Additional context

No response

@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Sep 5, 2024
@mattsse mattsse removed the S-needs-triage This issue needs to be labelled label Sep 5, 2024
@greged93
Copy link
Contributor

greged93 commented Sep 5, 2024

@mattsse can I take this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants