Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant impl NetworkManager #11387

Closed
mattsse opened this issue Oct 1, 2024 · 0 comments · Fixed by #11390
Closed

Remove redundant impl NetworkManager #11387

mattsse opened this issue Oct 1, 2024 · 0 comments · Fixed by #11390
Labels
A-networking Related to networking in general C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 1, 2024

Describe the feature

currently the NetworkManager has various impl blocks:

reth/crates/net/network/src/manager.rs

Line 953 in 86f12b7

impl NetworkManager {

reth/crates/net/network/src/manager.rs

Line 164 in 86f12b7

impl NetworkManager {

...

this is legacy from when this type was generic, we can remove those now

TODO

  • remove redundant impl blocks

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started C-debt A clean up/refactor of existing code labels Oct 1, 2024
@mattsse mattsse added A-networking Related to networking in general and removed C-enhancement New feature or request labels Oct 1, 2024
@nkysg nkysg mentioned this issue Oct 1, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-networking Related to networking in general C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Remove redundant impl NetworkManager nkysg/reth
1 participant
@mattsse