cleanup chainspec value parsers

[mattsse]

atm the chainspec parsers are still in the utils crate

reth/crates/node/core/src/args/utils.rs

Lines 27 to 42 in 9c9b1fd

	pub fn chain_value_parser(s: &str) -> eyre::Result<Arc<ChainSpec>, eyre::Error> {
	Ok(match s {
	"mainnet" => MAINNET.clone(),
	"sepolia" => SEPOLIA.clone(),
	"holesky" => HOLESKY.clone(),
	"dev" => DEV.clone(),
	_ => Arc::new(parse_custom_chain_spec(s)?),
	})
	}
	/// Clap value parser for [`OpChainSpec`](reth_optimism_chainspec::OpChainSpec)s.
	///
	/// The value parser matches either a known chain, the path
	/// to a json file, or a json formatted string in-memory. The json needs to be a Genesis struct.
	#[cfg(feature = "optimism")]
	pub fn chain_value_parser(s: &str) -> eyre::Result<Arc<ChainSpec>, eyre::Error> {

but they are no longer used in this crate. They should be moved to where the chainspec parsers are defined (chainspec crates).

we also need to rename:

reth/crates/node/core/src/args/utils.rs

Line 76 in 9c9b1fd

pub struct DefaultChainSpecParser;

to EthereumChainSpecParser

[garwahl]

Yeah I can do this

[garwahl]

Hey @mattsse it appears these parsing functions already exist in their corresponding crates
crates/ethereum/../chainspec.rs

reth/crates/ethereum/cli/src/chainspec.rs

Lines 10 to 12 in 6cb26f7

	fn chain_value_parser(s: &str) -> eyre::Result<Arc<ChainSpec>, eyre::Error> {
	Ok(match s {
	"mainnet" => MAINNET.clone(),

crates/optimism/../chainspec.rs

reth/crates/optimism/cli/src/chainspec.rs

Lines 12 to 14 in 2aa3dd0

	/// to a json file, or a json formatted string in-memory. The json needs to be a Genesis struct.
	fn chain_value_parser(s: &str) -> eyre::Result<Arc<OpChainSpec>, eyre::Error> {
	Ok(match s {

Wondering how the value parsers inutils.rs are used and if we want this duplication/ can they be removed?

[mattsse]

I think these are duplicated and we can remove if possible