Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move optimism execution types test to optimism crate #11792

Closed
Tracked by #7649
mattsse opened this issue Oct 16, 2024 · 2 comments · Fixed by #12026
Closed
Tracked by #7649

Move optimism execution types test to optimism crate #11792

mattsse opened this issue Oct 16, 2024 · 2 comments · Fixed by #12026
Labels
C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Oct 16, 2024 •
edited
Loading

This is a followup to

#11115

we need to remove the optimism feature from the execution-types crate, as prep, we need to duplicate all tests for OP just like #11115 first

TODO

  • duplicate the op specific tests in op crate
@mattsse mattsse mentioned this issue Oct 16, 2024
Closed
@mattsse mattsse added D-good-first-issue Nice and easy! A great choice to get started C-debt A clean up/refactor of existing code labels Oct 16, 2024
@YashBit
Copy link

YashBit commented Oct 16, 2024

@mattsse Please assign to me.

@Gerson2102
Copy link
Contributor

Hey can I work on this one?

@YashBit YashBit removed their assignment Oct 21, 2024
@l1nxy l1nxy mentioned this issue Oct 24, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: move optimism execution types test to optimism crate l1nxy/reth
3 participants
@mattsse @YashBit @Gerson2102