Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FileClient generic over codec #12475

Closed
Tracked by #7649
emhane opened this issue Nov 12, 2024 · 2 comments
Closed
Tracked by #7649

Make FileClient generic over codec #12475

emhane opened this issue Nov 12, 2024 · 2 comments
Assignees
@TropicalDog17
Labels
A-cli Related to the reth CLI C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started

Comments

@emhane
Copy link
Member

emhane commented Nov 12, 2024

Describe the feature

Add field codec: T to FileClient, and make generic over codec. Instead of using the hardcoded type BlockFileCodec here, get the codec by self.codec

reth/crates/net/downloaders/src/file_client.rs

Line 204 in aece53a

let mut stream = FramedRead::with_capacity(reader, BlockFileCodec, num_bytes as usize);

Additional context

No response
@emhane emhane added A-cli Related to the reth CLI C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started labels Nov 12, 2024
@emhane emhane mentioned this issue Nov 12, 2024
Closed
@TropicalDog17
Copy link
Contributor

Can I work on this @emhane ?

@emhane emhane mentioned this issue Nov 12, 2024
Closed
@TropicalDog17 TropicalDog17 mentioned this issue Nov 13, 2024
Closed
@emhane emhane mentioned this issue Nov 19, 2024
Merged
@emhane
Copy link
Member Author

emhane commented Nov 27, 2024

closed by #12681

@emhane emhane closed this as completed Nov 27, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TropicalDog17 TropicalDog17

Labels
A-cli Related to the reth CLI C-debt A clean up/refactor of existing code D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: make codec generic over FileClient TropicalDog17/reth
2 participants
@emhane @TropicalDog17