Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate OP payload builder in new engine #13440

Closed
Tracked by #7649
emhane opened this issue Dec 19, 2024 · 1 comment · Fixed by #13454
Closed
Tracked by #7649

Separate OP payload builder in new engine #13440

emhane opened this issue Dec 19, 2024 · 1 comment · Fixed by #13454
Labels
A-consensus Related to the consensus engine A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt A clean up/refactor of existing code S-needs-design This issue requires design work to think about how it would best be accomplished

Comments

@emhane
Copy link
Member

emhane commented Dec 19, 2024

Describe the feature

Remove optimism feature, either by making payload builder injectable or by copying engine impl to an op crate.

#[cfg(feature = "optimism")]
impl<ChainSpec> PayloadAttributesBuilder<op_alloy_rpc_types_engine::OpPayloadAttributes>
for LocalPayloadAttributesBuilder<ChainSpec>
where
ChainSpec: Send + Sync + EthereumHardforks + 'static,
{
fn build(&self, timestamp: u64) -> op_alloy_rpc_types_engine::OpPayloadAttributes {
op_alloy_rpc_types_engine::OpPayloadAttributes {
payload_attributes: self.build(timestamp),
transactions: None,
no_tx_pool: None,
gas_limit: None,
eip_1559_params: None,
}
}
}

Additional context

No response

@emhane emhane added A-consensus Related to the consensus engine A-op-reth Related to Optimism and op-reth labels Dec 19, 2024
@emhane emhane added C-debt A clean up/refactor of existing code A-sdk Related to reth's use as a library labels Dec 19, 2024
@emhane emhane added the S-needs-design This issue requires design work to think about how it would best be accomplished label Dec 19, 2024
@mattsse
Copy link
Collaborator

mattsse commented Dec 19, 2024

this feature is fine because this is done for optimism types, but this feature should be called op so that is distinguishable from the problematic one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Related to the consensus engine A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library C-debt A clean up/refactor of existing code S-needs-design This issue requires design work to think about how it would best be accomplished
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants