-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace Filter support #4799
Comments
Our use case is probably not all that typical (but no less useful). We only need I imagine that for others, though, the Our use case is indexing all address appearances in the block range, not filtering for one (or a few) addresses. We have a bunch of test cases for tracing that I'll run once I get my Reth node synced to mainnet. That will help with testing. |
what's a typical block range? since this is quite similar to replay_block with some extra steps, I can at least add support for block filters |
Again, no real typical value. We would probably adjust at whatever value is the fastest (after experimenting). We batch 5,000 blocks at a time, but I'm sure that's way too many, so I've been thinking of breaking it up into 100 50-block chunks. (Currently, we query each block separately with |
sg! |
I'll test it (once I'm synced...). Although, I have Sepolia synced, so I can test it there too. |
This issue is stale because it has been open for 21 days with no activity. |
Is this still an open issue? |
This is still an issue. The merged implementation is limited to 100 blocks, which makes it useless, compared to Erigon. |
Describe the feature
tracking issue for
trace_fitler
which is very useful for indexingref #3661 (comment)
trace_filter
returns parity traces similar toeth_getLogs
but for tracesreth/crates/rpc/rpc-types/src/eth/trace/filter.rs
Lines 9 to 24 in 7024e9a
all filter fields can be checked via Transactions alone, if I understand the filter options correctly.
Supporting the block range shouldn't be too difficult, at worst this is essentially a batch of replay_block requests.
Not sure how to support address fields without limiting blocks, because atm we don't have indices for that
@tjayrush what is a usual trace_filter request?
Additional context
No response
The text was updated successfully, but these errors were encountered: