Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing cancun header fields if empty payload #6324

Closed
1 task done
mattsse opened this issue Feb 1, 2024 · 0 comments · Fixed by #6328
Closed
1 task done

Missing cancun header fields if empty payload #6324

mattsse opened this issue Feb 1, 2024 · 0 comments · Fixed by #6328
Assignees
Labels
A-block-building Related to block building C-bug An unexpected or incorrect behavior

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 1, 2024

Describe the bug

when building empty payload blob fields are set to None

blob_gas_used: None,
excess_blob_gas: None,

resulting in empty list code instead of 0 value in encoding resulting in bad hash

out.put_u8(EMPTY_LIST_CODE);

Steps to reproduce

Node logs

-

Platform(s)

Linux (x86)

What version/commit are you on?

What database version are you on?

What type of node are you running?

Archive (default)

What prune config do you use, if any?

If you've built Reth from source, provide the full command you used

Code of Conduct

  • I agree to follow the Code of Conduct
@mattsse mattsse added C-bug An unexpected or incorrect behavior S-needs-triage This issue needs to be labelled labels Feb 1, 2024
@mattsse mattsse added A-block-building Related to block building and removed S-needs-triage This issue needs to be labelled labels Feb 1, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building C-bug An unexpected or incorrect behavior
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants